Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All-sky example useful for timing #220

Merged
merged 39 commits into from
Jul 4, 2023
Merged

All-sky example useful for timing #220

merged 39 commits into from
Jul 4, 2023

Conversation

RobertPincus
Copy link
Member

Revises the all-sky example to be useful for timing benchmarks. The atmospheric profile more-or-less follows the profile for RCEMIP at a surface temperature of 300 K. Users specify the number of columns and layers and may choose more than a single iteration. (Array checks are turned off for all but the first iteration). A k-distribution must be specified. Clouds are optional, and occupy 2/3 of columns; aerosols in every other column are optional but require clouds.

A netCDF file is produced; small files of {LW,SW}x{clouds, clouds+aerosols} are used for verification during continuous integration. Timing output is simple, i.e.

ncol   nlay   ngpt  clouds aerosols time_per_col_ms nloops time_total_s time_min_s
     2     32    128       0        0           0.978     24        0.047      0.047

Addresses #128

@RobertPincus
Remove GPTL, reorganize
c45b8dc
@RobertPincus
Refactored all-sky example, WIP
d2b404f
@RobertPincus
No GPTL in Makefile either
1f6b934
@RobertPincus
Refactor RH - why's nvfortran failing?
d159a39
@RobertPincus
Debugging prints
1825269
@RobertPincus
More debuggin
feeff71
@RobertPincus
Even more debuggin'
f4fe171
@RobertPincus
Explicit allocation?
3e3685b
@RobertPincus
EMD
35d310b
@RobertPincus
Put all subroutines with contains?
89b6245
@RobertPincus
Add RCE profiles to allsky example (unused so far)
80272b9
@RobertPincus
All-sky calculations use RCEMIP-ish profiles - no data written so not…
84a3e07 
…hing checked
@RobertPincus
Consistent OpenACC memory approach
5c05c91
@RobertPincus
Elemental functions need acc diretives
0f99ec2
@RobertPincus
Garand vestiges are removed; fluxes are written but not checked yet
3b4bd13
@RobertPincus
Remove elemental subroutine; update Makefile
0c28791
@RobertPincus
Remove elemental function
788808a
@RobertPincus
All the instances if you please
bfffbd3
@RobertPincus
Recompute Tv in stratosphere
982fd91
@RobertPincus
Create temps, pressures on the device only once.
1f8313e
@RobertPincus
Updates from develop branch
766494e
@RobertPincus
Checking of all-sky reference results
62cbf43
@RobertPincus
Include cloud and aerosol state in all-sky outputs; add no-aerosols case
4ce5523
@RobertPincus
Accelerator data management in all-sky example
2caba63
@RobertPincus
omp directive syntax
384beab
@RobertPincus
Syntax, relhum on GPU for compute_aerosols
808121b
@RobertPincus
Revised timing output from all-sky example
a1c0d7d
@RobertPincus
Conditional evaluation when computing profiles
2c1bae8
@RobertPincus
Add Python script to loop over ncol, nlay while specifying clouds, ae…
6446ab4 
…rosols
@RobertPincus
Extra print
2f512a2
@RobertPincus
Copy link
Member Author

Also: removes use of NCHOME environment variable, removes (optional) use of GPTL timing library in RFMIP examples.

@Chiil
Copy link
Collaborator

Chiil commented Jul 1, 2023

Design is great, tools works well. Compile and test sequence fails on my workstation because files are not adequately copied to reference in allsky test:

FileNotFoundError: [Errno 2] No such file or directory: '/home/chiel/devel/rte-rrtmgp/rrtmgp-data/examples/all-sky/reference/rrtmgp-allsky-lw-no-aerosols.nc'
make[1]: *** [Makefile:61: check] Error 1
make[1]: Leaving directory '/home/chiel/devel/rte-rrtmgp/examples/all-sky'

I only have a rrtmgp-allsky-no-aerosols.nc

@RobertPincus
Copy link
Member Author

@Chiil Thanks for the feedback. Did you check out branch feature-timing of the data repo as well?

@Chiil
Copy link
Collaborator

Chiil commented Jul 2, 2023 via email

@RobertPincus
Copy link
Member Author

@Chiil If you check out the feature-timing branch of the data repo, do you find all the data there that enables you to run the tests?

Chiil
Chiil approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@Chiil Chiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFMIP and all-sky test pass, flexible configurations work. Code can be merged to develop.

@RobertPincus RobertPincus merged commit 36d7969 into develop Jul 4, 2023
@RobertPincus RobertPincus deleted the feature-timing branch July 4, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiil Chiil Chiil approved these changes

@skosukhin skosukhin Awaiting requested review from skosukhin

@alexeedm alexeedm Awaiting requested review from alexeedm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobertPincus @Chiil @alexeedm